Make HTMLCollection and NodeList valid array types #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
as mentioned on a conversation on elm-slack about this issue, a known workaround is to use https://package.elm-lang.org/packages/debois/elm-dom/latest/DOM#childNodes or to adapt it to our needs |
|
I create an Ellie which logs the fail outputs of the decoders, to make it clearer what this Ellie is testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSCCE: https://ellie-app.com/8zCdXgf99qCa1
On the SSCCE above I would expect the decoders for both childNodes (NodeList) and children (HTMLCollection) to decode correctly to a list - this is similar to how it currently handles FileList.
Found this issue when trying to implement a flexible data table, similar to the one shown here: https://adamlynch.com/flexible-data-tables-with-css-grid/#resizing-columns-with-grid
This is similar to #9.